From: Walter Dörwald <walter@livinglogic.de>
Date: Mon, 24 Feb 2003 20:17:32 +0000 (+0000)
Subject: Change the test encoding from "ISO8859-1" to "ISO-8859-1"
X-Git-Tag: v2.3c1~1696
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=dd8766a65bed9b86f9309f9b743b5d0f1074779e;p=python

Change the test encoding from "ISO8859-1" to "ISO-8859-1"
(see SF bug #690309) and raise ImportErrors instead of
RuntimeErrors, so building Python continues even
if importing iconv_codecs fails.

This is a temporary fix until we get proper configure
support for "broken" iconv implementations.
---

diff --git a/Modules/_iconv_codec.c b/Modules/_iconv_codec.c
index 1d2e5d4138..a26a341423 100644
--- a/Modules/_iconv_codec.c
+++ b/Modules/_iconv_codec.c
@@ -671,17 +671,17 @@ init_iconv_codec(void)
     size_t outsize = sizeof(out);
     size_t res;
 
-    iconv_t hdl = iconv_open(UNICODE_ENCODING, "ISO8859-1");
+    iconv_t hdl = iconv_open(UNICODE_ENCODING, "ISO-8859-1");
 
     if (hdl == (iconv_t)-1) {
-        PyErr_SetString(PyExc_RuntimeError,
+        PyErr_SetString(PyExc_ImportError,
 	  "can't initialize the _iconv_codec module: iconv_open() failed");
 	return;
     }
 
     res = iconv(hdl, &inptr, &insize, &outptr, &outsize);
     if (res == (size_t)-1) {
-        PyErr_SetString(PyExc_RuntimeError,
+        PyErr_SetString(PyExc_ImportError,
 	  "can't initialize the _iconv_codec module: iconv() failed");
 	return;
     }
@@ -698,7 +698,7 @@ init_iconv_codec(void)
        byteswap = 1;
     else {
 	iconv_close(hdl);
-        PyErr_SetString(PyExc_RuntimeError,
+        PyErr_SetString(PyExc_ImportError,
 	  "can't initialize the _iconv_codec module: mixed endianess");
 	return;
     }