From: Georg Brandl <georg@python.org>
Date: Thu, 16 Nov 2006 17:08:48 +0000 (+0000)
Subject: Bug #1588217: don't parse "= " as a soft line break in binascii's
X-Git-Tag: v2.5.1c1~249
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=dd3bffb679f8c76ffb1ac9a9a4a7fb515e0f4447;p=python

Bug #1588217: don't parse "= " as a soft line break in binascii's
a2b_qp() function, instead leave it in the string as quopri.decode()
does.
 (backport from rev. 52765)
---

diff --git a/Lib/test/test_binascii.py b/Lib/test/test_binascii.py
index 8df450456e..8272ad91aa 100755
--- a/Lib/test/test_binascii.py
+++ b/Lib/test/test_binascii.py
@@ -134,7 +134,7 @@ class BinASCIITest(unittest.TestCase):
             pass
         else:
             self.fail("binascii.a2b_qp(**{1:1}) didn't raise TypeError")
-        self.assertEqual(binascii.a2b_qp("= "), "")
+        self.assertEqual(binascii.a2b_qp("= "), "= ")
         self.assertEqual(binascii.a2b_qp("=="), "=")
         self.assertEqual(binascii.a2b_qp("=AX"), "=AX")
         self.assertRaises(TypeError, binascii.b2a_qp, foo="bar")
diff --git a/Misc/NEWS b/Misc/NEWS
index d619308006..221acbb033 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -70,6 +70,10 @@ Core and builtins
 Extension Modules
 -----------------
 
+- Bug #1588217: don't parse "= " as a soft line break in binascii's
+  a2b_qp() function, instead leave it in the string as quopri.decode()
+  does.
+
 - Patch #838546: Make terminal become controlling in pty.fork()
 
 - Patch #1560695: Add .note.GNU-stack to ctypes' sysv.S so that
diff --git a/Modules/binascii.c b/Modules/binascii.c
index 3b2c8b254c..4dee45198e 100644
--- a/Modules/binascii.c
+++ b/Modules/binascii.c
@@ -1057,8 +1057,7 @@ binascii_a2b_qp(PyObject *self, PyObject *args, PyObject *kwargs)
 			in++;
 			if (in >= datalen) break;
 			/* Soft line breaks */
-			if ((data[in] == '\n') || (data[in] == '\r') ||
-			    (data[in] == ' ') || (data[in] == '\t')) {
+			if ((data[in] == '\n') || (data[in] == '\r')) {
 				if (data[in] != '\n') {
 					while (in < datalen && data[in] != '\n') in++;
 				}