From: Dirk-Willem van Gulik <dirkx@apache.org>
Date: Mon, 11 Feb 2008 21:06:58 +0000 (+0000)
Subject: Incorperate feedback of Rudiger.
X-Git-Tag: 2.3.0~988
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=dca366b400d83a8d002e0d5518ade1589e02a964;p=apache

Incorperate feedback of Rudiger.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@620610 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/cache/mod_disk_cache.c b/modules/cache/mod_disk_cache.c
index 3e991156cb..c1c1af6cdd 100644
--- a/modules/cache/mod_disk_cache.c
+++ b/modules/cache/mod_disk_cache.c
@@ -854,13 +854,6 @@ static apr_status_t store_headers(cache_handle_t *h, request_rec *r, cache_info
 
             rv = mkdir_structure(conf, dobj->hdrsfile, r->pool);
 
-            if (rv != APR_SUCCESS) {
-                ap_log_error(APLOG_MARK, APLOG_WARNING, rv, r->server,
-                    "disk_cache: could not create directory path to %s",
-                    dobj->hdrsfile);
-                return rv;
-            }
-
             rv = apr_file_mktemp(&dobj->tfd, dobj->tempfile,
                                  APR_CREATE | APR_WRITE | APR_BINARY | APR_EXCL,
                                  r->pool);
@@ -893,6 +886,7 @@ static apr_status_t store_headers(cache_handle_t *h, request_rec *r, cache_info
                 ap_log_error(APLOG_MARK, APLOG_WARNING, rv, r->server,
                     "disk_cache: rename tempfile to varyfile failed: %s -> %s",
                     dobj->tempfile, dobj->hdrsfile);
+                    apr_file_remove(dobj->tempfile, r->pool);
                 return rv;
             }
 
@@ -988,12 +982,6 @@ static apr_status_t store_headers(cache_handle_t *h, request_rec *r, cache_info
     rv = apr_file_remove(dobj->hdrsfile, r->pool);
     if (rv != APR_SUCCESS) {
         rv = mkdir_structure(conf, dobj->hdrsfile, r->pool);
-        if (rv != APR_SUCCESS) {
-            ap_log_error(APLOG_MARK, APLOG_WARNING, rv, r->server,
-                     "disk_cache: creating directories for hdrsfile %s failed",
-                     dobj->hdrsfile);
-            return rv;
-        }
     }
 
     rv = safe_file_rename(conf, dobj->tempfile, dobj->hdrsfile, r->pool);