From: Joe Watkins <krakjoe@php.net>
Date: Fri, 29 Apr 2016 09:19:55 +0000 (+0100)
Subject: fix size_t signed comparison
X-Git-Tag: php-7.0.7RC1~53
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=dbae1653daba7524f10642155c8c46a907970151;p=php

fix size_t signed comparison
---

diff --git a/ext/readline/readline_cli.c b/ext/readline/readline_cli.c
index 3332fa56e0..a90b1387df 100644
--- a/ext/readline/readline_cli.c
+++ b/ext/readline/readline_cli.c
@@ -106,7 +106,8 @@ static size_t readline_shell_ub_write(const char *str, size_t str_length) /* {{{
 	   caller (sapi_cli_single_write in sapi/cli) which will actually
 	   write due to -1 return code */
 	php_last_char = str[str_length-1];
-	return -1;
+
+	return (size_t) -1;
 }
 /* }}} */
 
diff --git a/sapi/cli/php_cli.c b/sapi/cli/php_cli.c
index 5d789d2626..978c8b332e 100644
--- a/sapi/cli/php_cli.c
+++ b/sapi/cli/php_cli.c
@@ -304,7 +304,7 @@ static size_t sapi_cli_ub_write(const char *str, size_t str_length) /* {{{ */
 	if (cli_shell_callbacks.cli_shell_ub_write) {
 		size_t ub_wrote;
 		ub_wrote = cli_shell_callbacks.cli_shell_ub_write(str, str_length);
-		if (ub_wrote > -1) {
+		if (ub_wrote != (size_t) -1) {
 			return ub_wrote;
 		}
 	}