From: Fred Drake <fdrake@acm.org>
Date: Sat, 5 Jan 2002 17:17:09 +0000 (+0000)
Subject: Time2Internaldate():  Call isinstance() once for each of the type tests
X-Git-Tag: v2.3c1~6881
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=db519205a2cd89eb43d7622bc3b37b8b8ea8a629;p=python

Time2Internaldate():  Call isinstance() once for each of the type tests
instead of possibly twice by using a sequence of types to check for.
Add a message to the ValueError that can be raised.
---

diff --git a/Lib/imaplib.py b/Lib/imaplib.py
index ed785ed3d4..04d4d87bb9 100644
--- a/Lib/imaplib.py
+++ b/Lib/imaplib.py
@@ -1069,14 +1069,14 @@ def Time2Internaldate(date_time):
     Return string in form: '"DD-Mmm-YYYY HH:MM:SS +HHMM"'
     """
 
-    if isinstance(date_time, int) or isinstance(date_time, float):
+    if isinstance(date_time, (int, float)):
         tt = time.localtime(date_time)
-    elif isinstance(date_time, tuple) or \
-             isinstance(date_time, time.struct_time):
+    elif isinstance(date_time, (tuple, time.struct_time)):
         tt = date_time
     elif isinstance(date_time, str):
         return date_time        # Assume in correct format
-    else: raise ValueError
+    else:
+        raise ValueError("date_time not of a known type")
 
     dt = time.strftime("%d-%b-%Y %H:%M:%S", tt)
     if dt[0] == '0':