From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 17 Dec 2015 21:55:23 +0000 (-0500)
Subject: Fix improper initialization order for readline.
X-Git-Tag: REL9_1_20~35
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=db462a44e22dbaa945eabac7f73d2a240037f75e;p=postgresql

Fix improper initialization order for readline.

Turns out we must set rl_basic_word_break_characters *before* we call
rl_initialize() the first time, because it will quietly copy that value
elsewhere --- but only on the first call.  (Love these undocumented
dependencies.)  I broke this yesterday in commit 2ec477dc8108339d;
like that commit, back-patch to all active branches.  Per report from
Pavel Stehule.
---

diff --git a/src/bin/psql/input.c b/src/bin/psql/input.c
index 14ac034b57..30c580c12d 100644
--- a/src/bin/psql/input.c
+++ b/src/bin/psql/input.c
@@ -346,8 +346,10 @@ initializeInput(int flags)
 		char		home[MAXPGPATH];
 
 		useReadline = true;
-		rl_initialize();
+
+		/* these two things must be done in this order: */
 		initialize_readline();
+		rl_initialize();
 
 		useHistory = true;
 		using_history();