From: Eric Snow <ericsnowcurrently@gmail.com>
Date: Wed, 3 Jun 2015 17:09:48 +0000 (-0600)
Subject: Issue #24377: Fix a ref leak in OrderedDict.__repr__.
X-Git-Tag: v3.5.0b3~101
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=db4061cb9d3c2a369fa49a3820ffc11854119da3;p=python

Issue #24377: Fix a ref leak in OrderedDict.__repr__.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index de915a1c91..c4bfa701e5 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -25,6 +25,8 @@ Library
 
 - Issue #24362: Simplify the C OrderedDict fast nodes resize logic.
 
+- Issue #24377: Fix a ref leak in OrderedDict.__repr__.
+
 
 What's New in Python 3.5.0 beta 2?
 ==================================
diff --git a/Objects/odictobject.c b/Objects/odictobject.c
index 79ac826207..55055ac099 100644
--- a/Objects/odictobject.c
+++ b/Objects/odictobject.c
@@ -1578,7 +1578,7 @@ odict_repr(PyODictObject *self)
             if (value == NULL) {
                 if (!PyErr_Occurred())
                     PyErr_SetObject(PyExc_KeyError, key);
-                return NULL;
+                goto Done;
             }
             pair = PyTuple_Pack(2, key, value);
             if (pair == NULL)