From: Michael Friedrich <michael.friedrich@icinga.com>
Date: Wed, 14 Aug 2019 11:14:43 +0000 (+0200)
Subject: Add unit test for Utility::CompareVersion
X-Git-Tag: v2.11.0~1^2~39^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=da982c256b5984d4bfc45cebcf5c67ae7418fea8;p=icinga2

Add unit test for Utility::CompareVersion
---

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 6c84fd1f2..bfcd83ffd 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -109,6 +109,7 @@ add_boost_test(base
     base_type/byname
     base_type/instantiate
     base_utility/parse_version
+    base_utility/compare_version
     base_utility/comparepasswords_works
     base_utility/comparepasswords_issafe
     base_utility/validateutf8
diff --git a/test/base-utility.cpp b/test/base-utility.cpp
index bf9b8429e..e25179229 100644
--- a/test/base-utility.cpp
+++ b/test/base-utility.cpp
@@ -18,6 +18,13 @@ BOOST_AUTO_TEST_CASE(parse_version)
 	BOOST_CHECK(Utility::ParseVersion("v2.11butactually3.0") == "v2.11butactually3.0");
 }
 
+BOOST_AUTO_TEST_CASE(compare_version)
+{
+	BOOST_CHECK(Utility::CompareVersion("2.10.5", Utility::ParseVersion("v2.10.4")) < 0);
+	BOOST_CHECK(Utility::CompareVersion("2.11.0", Utility::ParseVersion("2.11.0-0")) == 0);
+	BOOST_CHECK(Utility::CompareVersion("2.10.5", Utility::ParseVersion("2.11.0-0.rc1.1")) > 0);
+}
+
 BOOST_AUTO_TEST_CASE(comparepasswords_works)
 {
 	BOOST_CHECK(Utility::ComparePasswords("", ""));