From: Todd C. Miller Date: Wed, 16 Jun 2010 19:28:45 +0000 (-0400) Subject: Cast isalnum() arg to unsigned char. X-Git-Tag: SUDO_1_7_3~49 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=da8ac8206a4a6d70c1cd6ac1e95ec407fb370a77;p=sudo Cast isalnum() arg to unsigned char. --HG-- branch : 1.7 --- diff --git a/sudo.c b/sudo.c index bf44a3e52..b384d567c 100644 --- a/sudo.c +++ b/sudo.c @@ -708,10 +708,9 @@ init_vars(sudo_mode, envp) av[0] = user_shell; /* may be updated later */ if (NewArgc > 0) { - size_t cmnd_size; + size_t cmnd_size = 1024; char *cmnd, *src, *dst, **ap; - cmnd_size = 1024; cmnd = dst = emalloc(cmnd_size); for (ap = NewArgv; *ap != NULL; ap++) { for (src = *ap; *src != '\0'; src++) { @@ -723,7 +722,7 @@ init_vars(sudo_mode, envp) dst = new_cmnd + (dst - cmnd); cmnd = new_cmnd; } - if (isalnum(*src) || *src == '_' || *src == '-') { + if (isalnum((unsigned char)*src) || *src == '_' || *src == '-') { *dst++ = *src; } else { /* quote potential meta character */