From: Xinchen Hui <laruence@php.net>
Date: Thu, 21 Mar 2013 02:56:30 +0000 (+0800)
Subject: fix memory leak
X-Git-Tag: php-5.5.0beta2~41
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=da6916a770b7be6e029579a1d34302b5d2112ece;p=php

fix memory leak

the value shouldn't be ref, use z_add_ref is enough
---

diff --git a/ext/spl/spl_dllist.c b/ext/spl/spl_dllist.c
index 83610863e4..aa462dfd76 100644
--- a/ext/spl/spl_dllist.c
+++ b/ext/spl/spl_dllist.c
@@ -1246,7 +1246,6 @@ SPL_METHOD(SplDoublyLinkedList, add)
 	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "zz", &zindex, &value) == FAILURE) {
 		return;
 	}
-	SEPARATE_ARG_IF_REF(value);
 
 	intern = (spl_dllist_object*)zend_object_store_get_object(getThis() TSRMLS_CC);
 	index  = spl_offset_convert_to_long(zindex TSRMLS_CC);
@@ -1256,6 +1255,7 @@ SPL_METHOD(SplDoublyLinkedList, add)
 		return;
 	}
 
+	Z_ADDREF_P(value);
 	if (index == intern->llist->count) {
 		/* If index is the last entry+1 then we do a push because we're not inserting before any entry */
 		spl_ptr_llist_push(intern->llist, value TSRMLS_CC);