From: Manjusaka Date: Wed, 23 Jan 2019 07:08:38 +0000 (+0800) Subject: bpo-35726: Prevented QueueHandler formatting from affecting other handlers (GH-11537) X-Git-Tag: v3.8.0a1~57 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=da6424e96ada72c15c91bddb0a411acf7119e10a;p=python bpo-35726: Prevented QueueHandler formatting from affecting other handlers (GH-11537) QueueHandler.prepare() now makes a copy of the record before modifying and enqueueing it, to avoid affecting other handlers in the chain. --- diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py index e213e438c3..3727bf0677 100644 --- a/Lib/logging/handlers.py +++ b/Lib/logging/handlers.py @@ -27,6 +27,7 @@ import logging, socket, os, pickle, struct, time, re from stat import ST_DEV, ST_INO, ST_MTIME import queue import threading +import copy # # Some constants... @@ -1377,6 +1378,8 @@ class QueueHandler(logging.Handler): # exc_info and exc_text attributes, as they are no longer # needed and, if not None, will typically not be pickleable. msg = self.format(record) + # bpo-35726: make copy of record to avoid affecting other handlers in the chain. + record = copy.copy(record) record.message = msg record.msg = msg record.args = None diff --git a/Misc/NEWS.d/next/Library/2019-01-13-01-33-00.bpo-35726.dasdas.rst b/Misc/NEWS.d/next/Library/2019-01-13-01-33-00.bpo-35726.dasdas.rst new file mode 100644 index 0000000000..f47cdc128e --- /dev/null +++ b/Misc/NEWS.d/next/Library/2019-01-13-01-33-00.bpo-35726.dasdas.rst @@ -0,0 +1 @@ +QueueHandler.prepare() now makes a copy of the record before modifying and enqueueing it, to avoid affecting other handlers in the chain.