From: Fariborz Jahanian <fjahanian@apple.com>
Date: Wed, 16 Jun 2010 19:56:08 +0000 (+0000)
Subject: C return types must be complete as well.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=da59e09f1fd53350fcd949adbadd8148117f21b2;p=clang

C return types must be complete as well.
Moved check before we build the ObjCMessageExpr node.
(PR7386 related).



git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@106139 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp
index ed6e917f55..520ea2af91 100644
--- a/lib/Sema/SemaExprObjC.cpp
+++ b/lib/Sema/SemaExprObjC.cpp
@@ -1007,6 +1007,12 @@ Sema::OwningExprResult Sema::BuildInstanceMessage(ExprArg ReceiverE,
   if (CheckMessageArgumentTypes(Args, NumArgs, Sel, Method, false,
                                 LBracLoc, RBracLoc, ReturnType))
     return ExprError();
+  
+  if (!ReturnType->isVoidType()) {
+    if (RequireCompleteType(LBracLoc, ReturnType, 
+                            diag::err_illegal_message_expr_incomplete_type))
+      return ExprError();
+  }
 
   // Construct the appropriate ObjCMessageExpr instance.
   Expr *Result;
@@ -1018,11 +1024,6 @@ Sema::OwningExprResult Sema::BuildInstanceMessage(ExprArg ReceiverE,
   else
     Result = ObjCMessageExpr::Create(Context, ReturnType, LBracLoc, Receiver, 
                                      Sel, Method, Args, NumArgs, RBracLoc);
-  if (Context.getLangOptions().CPlusPlus && !ReturnType->isVoidType()) {
-    if (RequireCompleteType(LBracLoc, ReturnType, 
-                      diag::err_illegal_message_expr_incomplete_type))
-      return ExprError();
-    }
   return MaybeBindToTemporary(Result);
 }