From: Nikita Popov <nikita.ppv@gmail.com>
Date: Tue, 21 Jul 2020 08:32:08 +0000 (+0200)
Subject: Fix readline test after callback changes
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=da4262df6fde011b0de8eca47ab33ed685379a98;p=php

Fix readline test after callback changes

This one requires libedit and was probably missed for that reason.
---

diff --git a/ext/readline/tests/libedit_callback_handler_install_001.phpt b/ext/readline/tests/libedit_callback_handler_install_001.phpt
index 70351fd74b..527289a51e 100644
--- a/ext/readline/tests/libedit_callback_handler_install_001.phpt
+++ b/ext/readline/tests/libedit_callback_handler_install_001.phpt
@@ -14,11 +14,13 @@ function foo() {
 }
 
 var_dump(readline_callback_handler_install('testing: ', 'foo'));
-var_dump(readline_callback_handler_install('testing: ', 'foobar!'));
+try {
+    var_dump(readline_callback_handler_install('testing: ', 'foobar!'));
+} catch (TypeError $e) {
+    echo $e->getMessage(), "\n";
+}
 
 ?>
---EXPECTF--
+--EXPECT--
 bool(true)
-
-Warning: readline_callback_handler_install(): foobar! is not callable in %s on line %d
-bool(false)
+readline_callback_handler_install(): Argument #2 ($callback) must be a valid callback, function "foobar!" not found or invalid function name