From: Gregory P. Smith Date: Sun, 20 Jan 2008 01:32:00 +0000 (+0000) Subject: Document that zipfile decryption is insanely slow and fix a typo and X-Git-Tag: v2.6a1~510 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=da407232e02e4d983f72801803faa6d25b2a8162;p=python Document that zipfile decryption is insanely slow and fix a typo and blatant lie in a docstring (it is not useful for security regardless of how you spell it). --- diff --git a/Doc/library/zipfile.rst b/Doc/library/zipfile.rst index f1cfc1ba3b..e3c852b15b 100644 --- a/Doc/library/zipfile.rst +++ b/Doc/library/zipfile.rst @@ -21,7 +21,8 @@ added to individual archive members---for which see the :ref:`zipinfo-objects` documentation). It can handle ZIP files that use the ZIP64 extensions (that is ZIP files that are more than 4 GByte in size). It supports decryption of encrypted files in ZIP archives, but it currently cannot -create an encrypted file. +create an encrypted file. Decryption is extremely slow as it is +implemented in native python rather than C. For other archive formats, see the :mod:`bz2`, :mod:`gzip`, and :mod:`tarfile` modules. diff --git a/Lib/zipfile.py b/Lib/zipfile.py index 6feabbf220..9f5669e71b 100644 --- a/Lib/zipfile.py +++ b/Lib/zipfile.py @@ -302,7 +302,7 @@ class _ZipDecrypter: ZIP supports a password-based form of encryption. Even though known plaintext attacks have been found against it, it is still useful - for low-level securicy. + to be able to get data out of such a file. Usage: zd = _ZipDecrypter(mypwd)