From: Victor Stinner Date: Fri, 15 Sep 2017 12:37:42 +0000 (-0700) Subject: bpo-31234: Join timers in test_threading (#3598) X-Git-Tag: v3.7.0a1~26 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=da3e5cf961f9bcc4bb376386cfe7a2865325086c;p=python bpo-31234: Join timers in test_threading (#3598) Call the .join() method of threading.Timer timers to prevent the "threading_cleanup() failed to cleanup 1 threads" warning. --- diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py index af6796cd2e..f7c3680bda 100644 --- a/Lib/test/test_threading.py +++ b/Lib/test/test_threading.py @@ -1099,6 +1099,8 @@ class TimerTests(BaseTestCase): self.callback_event.wait() self.assertEqual(len(self.callback_args), 2) self.assertEqual(self.callback_args, [((), {}), ((), {})]) + timer1.join() + timer2.join() def _callback_spy(self, *args, **kwargs): self.callback_args.append((args[:], kwargs.copy()))