From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Fri, 4 Jun 2021 00:26:07 +0000 (-0700)
Subject: remove an unnecessary NULL guard on a call to free
X-Git-Tag: 2.47.3~5^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d9b266f9619b745d76fd4602a63b0f5c46079164;p=graphviz

remove an unnecessary NULL guard on a call to free

Calling free on NULL is a well-defined no-op.
---

diff --git a/lib/common/htmlparse.y b/lib/common/htmlparse.y
index 4571c0c32..1f1bf0d6e 100644
--- a/lib/common/htmlparse.y
+++ b/lib/common/htmlparse.y
@@ -142,7 +142,7 @@ free_fspan(Dt_t* d, fspan* p, Dtdisc_t* ds)
 	int i;
 	ti = p->lp.items;
 	for (i = 0; i < p->lp.nitems; i++) {
-	    if (ti->str) free (ti->str);
+	    free (ti->str);
 	    ti++;
 	}
 	free (p->lp.items);