From: Chad Rosier <mcrosier@apple.com>
Date: Tue, 19 Jul 2011 20:00:06 +0000 (+0000)
Subject: Refactor r135502 to avoid an empty if else condition, per Eric's suggestion (good... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d9259f373f2f0460a1ab12792b282d19bebfc2e2;p=clang

Refactor r135502 to avoid an empty if else condition, per Eric's suggestion (good call!).


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@135510 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp
index 2a68d68ee6..1b17e2e9ed 100644
--- a/lib/Basic/Targets.cpp
+++ b/lib/Basic/Targets.cpp
@@ -146,6 +146,14 @@ static void getDarwinDefines(MacroBuilder &Builder, const LangOptions &Opts,
     }
   }
 
+  // If -ccc-host-triple arch-pc-win32-macho option specified, we're
+  // generating code for Win32 ABI. No need to emit 
+  // __ENVIRONMENT_XX_OS_VERSION_MIN_REQUIRED__.
+  if (PlatformName == "win32") {
+    PlatformMinVersion = VersionTuple(Maj, Min, Rev);
+    return;
+  }
+
   // Set the appropriate OS version define.
   if (PlatformName == "ios") {
     assert(Maj < 10 && Min < 100 && Rev < 100 && "Invalid version!");
@@ -157,10 +165,6 @@ static void getDarwinDefines(MacroBuilder &Builder, const LangOptions &Opts,
     Str[4] = '0' + (Rev % 10);
     Str[5] = '\0';
     Builder.defineMacro("__ENVIRONMENT_IPHONE_OS_VERSION_MIN_REQUIRED__", Str);
-  } else if (PlatformName == "win32") {
-    // Due to option -ccc-host-triple arch-pc-win32-macho.
-    // Don't emit __ENVIRONMENT_XX_OS_VERSION_MIN_REQUIRED__ as we're generating
-    // code for Win32 ABI.
   } else {
     // Note that the Driver allows versions which aren't representable in the
     // define (because we only get a single digit for the minor and micro