From: Berker Peksag <berker.peksag@gmail.com>
Date: Mon, 5 Jan 2015 07:19:40 +0000 (+0200)
Subject: Issue #18644: Fix a ResourceWarning in formatter.test().
X-Git-Tag: v3.4.3rc1~177
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d91082c777fb6494a41f85bcf56bbe4ae5ad9d37;p=python

Issue #18644: Fix a ResourceWarning in formatter.test().

Patch by Vajrasky Kok.
---

diff --git a/Lib/formatter.py b/Lib/formatter.py
index d8cca52e30..9338261be7 100644
--- a/Lib/formatter.py
+++ b/Lib/formatter.py
@@ -436,11 +436,15 @@ def test(file = None):
         fp = open(sys.argv[1])
     else:
         fp = sys.stdin
-    for line in fp:
-        if line == '\n':
-            f.end_paragraph(1)
-        else:
-            f.add_flowing_data(line)
+    try:
+        for line in fp:
+            if line == '\n':
+                f.end_paragraph(1)
+            else:
+                f.add_flowing_data(line)
+    finally:
+        if fp is not sys.stdin:
+            fp.close()
     f.end_paragraph(0)