From: Daniel Dunbar <daniel@zuster.org>
Date: Sun, 3 May 2009 11:41:43 +0000 (+0000)
Subject: Fix a possible memory error, the record layout entry could be
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d8fd6ff0ea47ba63f836d0f4e6a1bee49863f64a;p=clang

Fix a possible memory error, the record layout entry could be
invalidated by layout out the super class, we cannot cache the map
entry.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@70693 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/AST/ASTContext.cpp b/lib/AST/ASTContext.cpp
index 65c9cddd9d..f58291ee21 100644
--- a/lib/AST/ASTContext.cpp
+++ b/lib/AST/ASTContext.cpp
@@ -745,9 +745,10 @@ const ASTRecordLayout &
 ASTContext::getObjCLayout(const ObjCInterfaceDecl *D,
                           const ObjCImplementationDecl *Impl) {
   // Look up this layout, if already laid out, return what we have.
-  const ASTRecordLayout *&Entry = 
-    ObjCLayouts[Impl ? (ObjCContainerDecl*) Impl : (ObjCContainerDecl*) D];
-  if (Entry) return *Entry;
+  ObjCContainerDecl *Key = 
+    Impl ? (ObjCContainerDecl*) Impl : (ObjCContainerDecl*) D;
+  if (const ASTRecordLayout *Entry = ObjCLayouts[Key])
+    return *Entry;
 
   unsigned FieldCount = D->ivar_size();
   // Add in synthesized ivar count if laying out an implementation.
@@ -757,7 +758,7 @@ ASTContext::getObjCLayout(const ObjCInterfaceDecl *D,
       if ((*I)->getPropertyIvarDecl())
         ++FieldCount;
 
-    // If there aren't any sythesized ivar's then reuse the interface
+    // If there aren't any sythesized ivars then reuse the interface
     // entry. Note we can't cache this because we simply free all
     // entries later; however we shouldn't look up implementations
     // frequently.
@@ -765,23 +766,21 @@ ASTContext::getObjCLayout(const ObjCInterfaceDecl *D,
       return getObjCLayout(D, 0);
   }
 
-  // Allocate and assign into ASTRecordLayouts here.  The "Entry" reference can
-  // be invalidated (dangle) if the ASTRecordLayouts hashtable is inserted into.
   ASTRecordLayout *NewEntry = NULL;
   if (ObjCInterfaceDecl *SD = D->getSuperClass()) {
     FieldCount++;
     const ASTRecordLayout &SL = getASTObjCInterfaceLayout(SD);
     unsigned Alignment = SL.getAlignment();
     uint64_t Size = SL.getSize();
-    NewEntry = new ASTRecordLayout(Size, Alignment);
+
+    ObjCLayouts[Key] = NewEntry = new ASTRecordLayout(Size, Alignment);
     NewEntry->InitializeLayout(FieldCount);
     // Super class is at the beginning of the layout.
     NewEntry->SetFieldOffset(0, 0);
   } else {
-    NewEntry = new ASTRecordLayout();
+    ObjCLayouts[Key] = NewEntry = new ASTRecordLayout();
     NewEntry->InitializeLayout(FieldCount);
   }
-  Entry = NewEntry;
 
   unsigned StructPacking = 0;
   if (const PackedAttr *PA = D->getAttr<PackedAttr>())