From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 9 Jul 2019 10:44:17 +0000 (+0200)
Subject: Add -Wformat=2 since -Wformat is required for -Wformat-security
X-Git-Tag: dnsdist-1.4.0-rc1~60^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d8bcbd108f85295572df07bad1db228415cb7619;p=pdns

Add -Wformat=2 since -Wformat is required for -Wformat-security
---

diff --git a/.circleci/config.yml b/.circleci/config.yml
index fd5966996..ac24a1265 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -454,8 +454,8 @@ jobs:
       - run:
           name: configure
           command: |
-            CFLAGS="-O1 -Werror=vla -Werror=format-security" \
-            CXXFLAGS="-O1 -Werror=vla -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
+            CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \
+            CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
             ./configure \
               --disable-lua-records \
               --with-modules='bind lmdb ldap gmysql gsqlite3 gpgsql godbc mydns random tinydns' \
@@ -798,8 +798,8 @@ jobs:
       - run:
           name: configure
           command: |
-            CFLAGS="-O1 -Werror=vla -Werror=format-security" \
-            CXXFLAGS="-O1 -Werror=vla -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
+            CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \
+            CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
             ./configure \
             --enable-unit-tests \
             --enable-nod \
@@ -964,8 +964,8 @@ jobs:
       - run:
           name: configure
           command: |
-            CFLAGS="-O1 -Werror=vla -Werror=format-security" \
-            CXXFLAGS="-O1 -Werror=vla -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
+            CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \
+            CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
             ./configure \
               --disable-lua-records \
               --with-modules='bind lmdb ldap gmysql gsqlite3 gpgsql godbc mydns random tinydns' \
@@ -1032,8 +1032,8 @@ jobs:
       - run:
           name: configure
           command: |
-            CFLAGS="-O1 -Werror=vla -Wformat -Werror=format-security" \
-            CXXFLAGS="-O1 -Werror=vla -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
+            CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \
+            CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
             ./configure \
             --disable-systemd \
             --disable-unit-tests \
@@ -1104,8 +1104,8 @@ jobs:
       - run:
           name: configure
           command: |
-            CFLAGS="-O1 -Werror=vla -Werror=format-security" \
-            CXXFLAGS="-O1 -Werror=vla -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
+            CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \
+            CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
             ./configure \
             --disable-systemd \
             --disable-unit-tests \
@@ -1176,8 +1176,8 @@ jobs:
       - run:
           name: configure
           command: |
-            CFLAGS="-O1 -Werror=vla -Wformat -Werror=format-security" \
-            CXXFLAGS="-O1 -Werror=vla -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
+            CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \
+            CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
             ./configure \
             --enable-unit-tests \
             --enable-dnstap \