From: Rob Richards <rrichards@php.net>
Date: Sat, 19 Jul 2003 14:59:29 +0000 (+0000)
Subject: fix for Bug #24715 segfault in dom_document_create_element
X-Git-Tag: BEFORE_ARG_INFO~192
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d85845a64b0dc05a1417091d7b4cf8bacb8aeaca;p=php

fix for Bug #24715 segfault in dom_document_create_element
removed xmlmemorydump debug code
---

diff --git a/ext/dom/document.c b/ext/dom/document.c
index 491681f838..2fdab8c799 100644
--- a/ext/dom/document.c
+++ b/ext/dom/document.c
@@ -451,16 +451,16 @@ PHP_FUNCTION(dom_document_create_element)
 	xmlNode *node;
 	xmlDocPtr docp;
 	dom_object *intern;
-	int ret, name_len;
-	char *name;
+	int ret, name_len, value_len;
+	char *name, *value = NULL;
 
 	DOM_GET_THIS_OBJ(docp, id, xmlDocPtr, intern);
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|s", &name, &name_len) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|s", &name, &name_len, &value, &value_len) == FAILURE) {
 		return;
 	}
 
-	node = xmlNewDocNode(docp, NULL, name, NULL);
+	node = xmlNewDocNode(docp, NULL, name, value);
 	if (!node) {
 		RETURN_FALSE;
 	}
diff --git a/ext/dom/php_dom.c b/ext/dom/php_dom.c
index c23d30436b..c6ff95fa57 100644
--- a/ext/dom/php_dom.c
+++ b/ext/dom/php_dom.c
@@ -659,7 +659,7 @@ PHP_MSHUTDOWN_FUNCTION(dom)
 	uncomment the following line, this will tell you the amount of not freed memory
 	and the total used memory into apaches error_log  */
 /*  xmlMemoryDump();*/
-xmlMemoryDump();
+
 	return SUCCESS;
 }