From: Antoine Pitrou <solipsis@pitrou.net>
Date: Tue, 14 Jan 2014 20:02:43 +0000 (+0100)
Subject: Replace assert with a proper error
X-Git-Tag: v3.4.0b3~143
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d7fb7919e352994231182c30a620e677eb288563;p=python

Replace assert with a proper error
---

diff --git a/Tools/clinic/clinic.py b/Tools/clinic/clinic.py
index 3d4feafd7f..56e491168e 100755
--- a/Tools/clinic/clinic.py
+++ b/Tools/clinic/clinic.py
@@ -2343,9 +2343,11 @@ class DSLParser:
                 fail("Badly-formed annotation for " + full_name + ": " + returns)
             try:
                 name, legacy, kwargs = self.parse_converter(module.body[0].returns)
-                assert not legacy
+                if legacy:
+                    fail("Legacy converter {!r} not allowed as a return converter"
+                         .format(name))
                 if name not in return_converters:
-                    fail("Error: No available return converter called " + repr(name))
+                    fail("No available return converter called " + repr(name))
                 return_converter = return_converters[name](**kwargs)
             except ValueError:
                 fail("Badly-formed annotation for " + full_name + ": " + returns)