From: Bram Moolenaar Date: Mon, 23 Mar 2020 21:46:44 +0000 (+0100) Subject: patch 8.2.0438: terminal noblock test is very flaky on BSD X-Git-Tag: v8.2.0438 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d7b7770f11c16cfac707b5048c61e722dcc903a6;p=vim patch 8.2.0438: terminal noblock test is very flaky on BSD Problem: Terminal noblock test is very flaky on BSD. Solution: Change WaitFor() to WaitForAssert() to be able to see why it failed. Add a short wait in between sending keys. --- diff --git a/src/testdir/test_terminal.vim b/src/testdir/test_terminal.vim index 6d7c78615..7e7aaff94 100644 --- a/src/testdir/test_terminal.vim +++ b/src/testdir/test_terminal.vim @@ -675,13 +675,14 @@ func Test_terminal_noblock() for c in split('abcdefghijklmnopqrstuvwxyz', '\zs') call term_sendkeys(buf, 'echo ' . repeat(c, len) . "\") + call term_wait(buf, 1) endfor call term_sendkeys(buf, "echo done\") " On MS-Windows there is an extra empty line below "done". Find "done" in " the last-but-one or the last-but-two line. let lnum = term_getsize(buf)[0] - 1 - call WaitFor({-> term_getline(buf, lnum) =~ "done" || term_getline(buf, lnum - 1) =~ "done"}, 10000) + call WaitForAssert({-> assert_match('done', term_getline(buf, lnum - 1) .. '//' .. term_getline(buf, lnum))}) let line = term_getline(buf, lnum) if line !~ 'done' let line = term_getline(buf, lnum - 1) diff --git a/src/version.c b/src/version.c index eef374a67..82d93e529 100644 --- a/src/version.c +++ b/src/version.c @@ -738,6 +738,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 438, /**/ 437, /**/