From: Raymond Hettinger <python@rcn.com>
Date: Tue, 3 Feb 2009 02:23:19 +0000 (+0000)
Subject: Validate that __length_hint__ returns a usable result.
X-Git-Tag: v2.7a1~2136
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d6fc2623c5e765df20f2072aa6575b0c5c272692;p=python

Validate that __length_hint__ returns a usable result.
---

diff --git a/Lib/test/test_iterlen.py b/Lib/test/test_iterlen.py
index 91873c2af4..ab5466ecf9 100644
--- a/Lib/test/test_iterlen.py
+++ b/Lib/test/test_iterlen.py
@@ -208,6 +208,11 @@ class BadLengthHint(object):
     def __length_hint__(self):
         raise RuntimeError('hello')
 
+class NoneLengthHint(object):
+    def __iter__(self): return iter(range(10))
+    def __length_hint__(self):
+        return None
+
 class TestLengthHintExceptions(unittest.TestCase):
 
     def test_issue1242657(self):
@@ -225,6 +230,11 @@ class TestLengthHintExceptions(unittest.TestCase):
         self.assertRaises(RuntimeError, b.extend, BadLen())
         self.assertRaises(RuntimeError, b.extend, BadLengthHint())
 
+    def test_invalid_hint(self):
+        # Make sure an invalid result doesn't muck-up the works
+        self.assertEqual(list(NoneLengthHint()), list(range(10)))
+
+
 def test_main():
     unittests = [
         TestRepeat,
diff --git a/Objects/abstract.c b/Objects/abstract.c
index 1ac4ac95b5..d601288458 100644
--- a/Objects/abstract.c
+++ b/Objects/abstract.c
@@ -123,7 +123,7 @@ _PyObject_LengthHint(PyObject *o, Py_ssize_t defaultvalue)
 		PyErr_Clear();
 		return defaultvalue;
 	}
-	rv = PyInt_AsLong(ro);
+	rv = rv = PyLong_Check(ro) ? PyLong_AsSsize_t(ro) : defaultvalue;
 	Py_DECREF(ro);
 	return rv;
 }