From: Ard Biesheuvel <abies@php.net>
Date: Tue, 4 May 2004 12:42:54 +0000 (+0000)
Subject: ibase_query(): Be careful not to return true on error conditions
X-Git-Tag: RELEASE_0_1~296
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d6838a86f355f82dfde3c12253617924d7421896;p=php

ibase_query(): Be careful not to return true on error conditions
---

diff --git a/ext/interbase/ibase_query.c b/ext/interbase/ibase_query.c
index a29a64c328..e8436c03a4 100644
--- a/ext/interbase/ibase_query.c
+++ b/ext/interbase/ibase_query.c
@@ -941,7 +941,7 @@ static int _php_ibase_exec(INTERNAL_FUNCTION_PARAMETERS, ibase_result **ib_resul
 			return SUCCESS;
 
 		default:
-			RETVAL_TRUE;
+			RETVAL_FALSE;
 	}
 
 	/* allocate sqlda and output buffers */
@@ -1027,7 +1027,11 @@ static int _php_ibase_exec(INTERNAL_FUNCTION_PARAMETERS, ibase_result **ib_resul
 			if (affected_rows > 0) {
 				ib_query->trans->affected_rows = affected_rows;
 				RETVAL_LONG(affected_rows);
+				break;
 			}
+			
+		default:
+			RETVAL_TRUE;
 	}
 
 	rv = SUCCESS;