From: Dr. Stephen Henson <steve@openssl.org>
Date: Wed, 16 Nov 2011 13:28:35 +0000 (+0000)
Subject: In EC_KEY_set_public_key_affine_coordinates include explicit check to see passed... 
X-Git-Tag: master-pre-reformat~2027
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d674bb4bc84e6e8cf510adfe7049cb19a2c29cf8;p=openssl

In EC_KEY_set_public_key_affine_coordinates include explicit check to see passed components do not exceed field order
---

diff --git a/crypto/ec/ec_key.c b/crypto/ec/ec_key.c
index f3331e1ce5..24ae707560 100644
--- a/crypto/ec/ec_key.c
+++ b/crypto/ec/ec_key.c
@@ -511,10 +511,12 @@ int EC_KEY_set_public_key_affine_coordinates(EC_KEY *key, BIGNUM *x, BIGNUM *y)
 								tx, ty, ctx))
 			goto err;
 		}
-	/* Check if retrieved coordinates match originals: if not values
-	 * are out of range.
+	/* Check if retrieved coordinates match originals and are less than
+	 * field order: if not values are out of range.
 	 */
-	if (BN_cmp(x, tx) || BN_cmp(y, ty))
+	if (BN_cmp(x, tx) || BN_cmp(y, ty)
+		|| (BN_cmp(x, &key->group->field) >= 0)
+		|| (BN_cmp(y, &key->group->field) >= 0))
 		{
 		ECerr(EC_F_EC_KEY_SET_PUBLIC_KEY_AFFINE_COORDINATES,
 			EC_R_COORDINATES_OUT_OF_RANGE);