From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Tue, 6 May 2014 12:14:51 +0000 (+0300)
Subject: Fix use of free in walsender error handling after a sysid mismatch.
X-Git-Tag: REL9_0_18~45
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d65ecdf4110bb352527dd2f6de31421d5b769258;p=postgresql

Fix use of free in walsender error handling after a sysid mismatch.

Found via valgrind. The bug exists since the introduction of the walsender,
so backpatch to 9.0.

Andres Freund
---

diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
index 8f1c592f48..d2786fdf8b 100644
--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -133,6 +133,7 @@ libpqrcv_connect(char *conninfo, XLogRecPtr startpoint)
 			 GetSystemIdentifier());
 	if (strcmp(primary_sysid, standby_sysid) != 0)
 	{
+		primary_sysid = pstrdup(primary_sysid);
 		PQclear(res);
 		ereport(ERROR,
 				(errmsg("database system identifier differs between the primary and standby"),