From: Sami Kerola <kerolasa@iki.fi>
Date: Wed, 8 Feb 2012 21:35:32 +0000 (+0100)
Subject: killall: fix potential string overflow [cppcheck]
X-Git-Tag: v22.16~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d65e2fb891da3797c4d5a62a1adeee6f48d17e02;p=psmisc

killall: fix potential string overflow [cppcheck]

[src/killall.c:138]: (warning) scanf without field width limits can crash with huge input data

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/src/killall.c b/src/killall.c
index 656a335..f108c77 100644
--- a/src/killall.c
+++ b/src/killall.c
@@ -135,7 +135,7 @@ uptime()
    }
    savelocale = setlocale(LC_NUMERIC, NULL);
    setlocale(LC_NUMERIC,"C");
-   if (fscanf(file, "%s", buf) == EOF) perror("uptime");
+   if (fscanf(file, "%2047s", buf) == EOF) perror("uptime");
    fclose(file);
    setlocale(LC_NUMERIC,savelocale);
    return atof(buf);