From: Fariborz Jahanian Date: Mon, 16 Aug 2010 17:58:53 +0000 (+0000) Subject: Fix a crash when parsing malformed out-of-line member function X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d6577428627bd4b7f8cd87e213151ebe6a587a9f;p=clang Fix a crash when parsing malformed out-of-line member function definition. radar 8307865. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@111163 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Parse/ParseDecl.cpp b/lib/Parse/ParseDecl.cpp index b0d9da5845..7149d4dc30 100644 --- a/lib/Parse/ParseDecl.cpp +++ b/lib/Parse/ParseDecl.cpp @@ -2727,7 +2727,10 @@ void Parser::ParseDirectDeclarator(Declarator &D) { if (Actions.ShouldEnterDeclaratorScope(getCurScope(), D.getCXXScopeSpec())) // Change the declaration context for name lookup, until this function // is exited (and the declarator has been parsed). - DeclScopeObj.EnterDeclaratorScope(); + // If there was an error parsing parenthesized declarator, declarator + // scope may have been enterred before. Don't do it again. + if (!D.isInvalidType()) + DeclScopeObj.EnterDeclaratorScope(); } } else if (D.mayOmitIdentifier()) { // This could be something simple like "int" (in which case the declarator diff --git a/test/Parser/cxx-decl.cpp b/test/Parser/cxx-decl.cpp index e4c703c334..e00ffd070f 100644 --- a/test/Parser/cxx-decl.cpp +++ b/test/Parser/cxx-decl.cpp @@ -76,3 +76,10 @@ class Class2 { } // no ; typedef Class1 Type1; // expected-error {{cannot combine with previous 'class' declaration specifier}} + +// rdar : // 8307865 +struct CodeCompleteConsumer { +}; + +void CodeCompleteConsumer::() { // expected-error {{xpected unqualified-id}} +}