From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sat, 31 Oct 2020 03:20:41 +0000 (-0700)
Subject: make compiler warnings for CMake Linux/macOS builds fail CI
X-Git-Tag: 2.46.0~20^2^2^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d6478b22a6055a5cf52ebd5822867228f6c7fb4c;p=graphviz

make compiler warnings for CMake Linux/macOS builds fail CI

Now that these builds are warning-free, we can "turn the ratchet" to demand they
stay warning-free or constitute a regression.
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index b8c7b6267..4a74576d4 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -268,6 +268,9 @@ ubuntu18-04-cmake-build:
     <<: *deb_build_definition
     before_script:
         - export build_system="cmake"
+        # fail on any compiler warnings
+        - export CFLAGS=-Werror
+        - export CXXFLAGS=-Werror
         - echo experimental > COLLECTION
     tags:
         - linux
@@ -277,6 +280,9 @@ centos7-cmake-build:
     <<: *rpm_build_definition
     before_script:
         - export build_system="cmake"
+        # fail on any compiler warnings
+        - export CFLAGS=-Werror
+        - export CXXFLAGS=-Werror
         - echo experimental > COLLECTION
     tags:
         - linux
@@ -286,6 +292,9 @@ fedora31-cmake-build:
     <<: *rpm_build_definition
     before_script:
         - export build_system="cmake"
+        # fail on any compiler warnings
+        - export CFLAGS=-Werror
+        - export CXXFLAGS=-Werror
         - echo experimental > COLLECTION
     tags:
         - linux
@@ -295,6 +304,9 @@ macos-cmake-build:
     <<: *macos_build_definition
     before_script:
         - export build_system="cmake"
+        # fail on any compiler warnings
+        - export CFLAGS=-Werror
+        - export CXXFLAGS=-Werror
     tags:
         - macos