From: David Bolvansky <david.bolvansky@gmail.com>
Date: Thu, 11 Jul 2019 20:14:22 +0000 (+0000)
Subject: [UpdateTestChecks] Emit warning when invalid test paths
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d631e100264b6135aab133c03ec29325da1dc98f;p=llvm

[UpdateTestChecks] Emit warning when invalid test paths

Summary:
Recently I ran into the following issue:

./update_test_checks.py /path/not-existing-file.ll

The script was silent and I was suprised why the real test file hadn't been updated.

Solution:
Emit warning if we detect this problem.



Reviewers: lebedev.ri, spatel, jdoerfert, nikic

Reviewed By: lebedev.ri, spatel, jdoerfert, nikic

Subscribers: jdoerfert, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64572

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@365818 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/utils/update_test_checks.py b/utils/update_test_checks.py
index de2900a4ab6..92ce0535a10 100755
--- a/utils/update_test_checks.py
+++ b/utils/update_test_checks.py
@@ -73,7 +73,13 @@ def main():
     sys.exit(1)
   opt_basename = 'opt'
 
-  test_paths = [test for pattern in args.tests for test in glob.glob(pattern)]
+  test_paths = []
+  for test in args.tests:
+    if not glob.glob(test):
+      print('WARNING: Test file \'%s\' was not found. Ignoring it.' % (test,), file=sys.stderr)
+      continue
+    test_paths.append(test)
+
   for test in test_paths:
     if args.verbose:
       print('Scanning for RUN lines in test file: %s' % (test,), file=sys.stderr)