From: Ronald Oussoren <ronaldoussoren@mac.com>
Date: Sun, 8 Oct 2006 17:51:46 +0000 (+0000)
Subject: MacOSX: The universal build requires that users have the MacOSX10.4u SDK
X-Git-Tag: v2.6a1~2587
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d6272a3cf6cf791abd25b03a2e418d2b382411a7;p=python

MacOSX: The universal build requires that users have the MacOSX10.4u SDK
installed to build extensions. This patch makes distutils emit a warning when
the compiler should use an SDK but that SDK is not installed, hopefully reducing
some confusion.
---

diff --git a/Lib/distutils/unixccompiler.py b/Lib/distutils/unixccompiler.py
index 6cd14f7728..d1fd1d9511 100644
--- a/Lib/distutils/unixccompiler.py
+++ b/Lib/distutils/unixccompiler.py
@@ -82,6 +82,22 @@ def _darwin_compiler_fixup(compiler_so, cc_args):
         except ValueError:
             pass
 
+    # Check if the SDK that is used during compilation actually exists, 
+    # the universal build requires the usage of a universal SDK and not all
+    # users have that installed by default.
+    sysroot = None
+    if '-isysroot' in cc_args:
+        idx = cc_args.index('-isysroot')
+        sysroot = cc_args[idx+1]
+    elif '-isysroot' in compiler_so:
+        idx = compiler_so.index('-isysroot')
+        sysroot = compiler_so[idx+1]
+
+    if sysroot and not os.path.isdir(sysroot):
+        log.warn("Compiling with an SDK that doesn't seem to exist: %s",
+                sysroot)
+        log.warn("Please check your Xcode installation")
+
     return compiler_so
 
 class UnixCCompiler(CCompiler):