From: Antoine Pitrou <solipsis@pitrou.net>
Date: Wed, 9 May 2012 11:24:31 +0000 (+0200)
Subject: Issue #14761: Fix potential leak on an error case in the import machinery.
X-Git-Tag: v3.3.0a4~220^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d576c711a510204604f707e1cbf773b4a39f21a3;p=python

Issue #14761: Fix potential leak on an error case in the import machinery.
---

diff --git a/Misc/ACKS b/Misc/ACKS
index 939e567441..6d8b6dddd2 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -145,6 +145,7 @@ Tony Campbell
 Brett Cannon
 Mike Carlton
 Terry Carroll
+Damien Cassou
 Lorenzo M. Catucci
 Donn Cave
 Charles Cazabon
diff --git a/Misc/NEWS b/Misc/NEWS
index e02489bcf0..b6bc463a5d 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,8 @@ What's New in Python 3.2.4
 Core and Builtins
 -----------------
 
+- Issue #14761: Fix potential leak on an error case in the import machinery.
+
 - Issue #14699: Fix calling the classmethod descriptor directly.
 
 - Issue #14433: Prevent msvcrt crash in interactive prompt when stdin
diff --git a/Python/import.c b/Python/import.c
index 1d3a4859da..598b7e09d9 100644
--- a/Python/import.c
+++ b/Python/import.c
@@ -1293,7 +1293,7 @@ load_source_module(char *name, char *pathname, FILE *fp)
     FILE *fpc;
     char *buf;
     char *cpathname;
-    PyCodeObject *co;
+    PyCodeObject *co = NULL;
     PyObject *m;
 
     if (fstat(fileno(fp), &st) != 0) {
@@ -1350,6 +1350,7 @@ load_source_module(char *name, char *pathname, FILE *fp)
     return m;
 
 error_exit:
+    Py_XDECREF(co);
     PyMem_FREE(buf);
     return NULL;
 }