From: Erich Keane <erich.keane@intel.com>
Date: Fri, 9 Feb 2018 00:13:49 +0000 (+0000)
Subject: Fix UBSan issue with PPC::isValidCPUName
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d5490e967eb423bebee97c7d3b6a43d39ae8bb2e;p=clang

Fix UBSan issue with PPC::isValidCPUName

Apparently storing the pointer to a StringLiteral as
a StringRef caused this section of code to issue a ubsan
warning.  This will hopefully fix that.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@324687 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Basic/Targets/PPC.cpp b/lib/Basic/Targets/PPC.cpp
index 40211dba28..3516a73809 100644
--- a/lib/Basic/Targets/PPC.cpp
+++ b/lib/Basic/Targets/PPC.cpp
@@ -493,8 +493,7 @@ static constexpr llvm::StringLiteral ValidCPUNames[] = {
 };
 
 bool PPCTargetInfo::isValidCPUName(StringRef Name) const {
-  const StringRef *FoundName = llvm::find(ValidCPUNames, Name);
-  return FoundName != std::end(ValidCPUNames);
+  return llvm::find(ValidCPUNames, Name) != std::end(ValidCPUNames);
 }
 
 void PPCTargetInfo::fillValidCPUList(SmallVectorImpl<StringRef> &Values) const {