From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 15 Oct 2018 18:01:38 +0000 (-0400)
Subject: Check for stack overrun in standard_ProcessUtility().
X-Git-Tag: REL_12_BETA1~1392
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d48da369ab22a8326d4d3d2b05b574d581057193;p=postgresql

Check for stack overrun in standard_ProcessUtility().

ProcessUtility can recurse, and indeed can be driven to infinite
recursion, so it ought to have a check_stack_depth() call.  This
covers the reported bug (portal trying to execute itself) and a bunch
of other cases that could perhaps arise somewhere.

Per bug #15428 from Malthe Borch.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/15428-b3c2915ec470b033@postgresql.org
---

diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c
index ede1621d3e..970c94ee80 100644
--- a/src/backend/tcop/utility.c
+++ b/src/backend/tcop/utility.c
@@ -387,6 +387,9 @@ standard_ProcessUtility(PlannedStmt *pstmt,
 	bool		isAtomicContext = (!(context == PROCESS_UTILITY_TOPLEVEL || context == PROCESS_UTILITY_QUERY_NONATOMIC) || IsTransactionBlock());
 	ParseState *pstate;
 
+	/* This can recurse, so check for excessive recursion */
+	check_stack_depth();
+
 	check_xact_readonly(parsetree);
 
 	if (completionTag)