From: Neal Norwitz <nnorwitz@gmail.com>
Date: Tue, 1 Apr 2008 05:40:43 +0000 (+0000)
Subject: Be sure to close the file.  2 places were deleting the file, so it was probably
X-Git-Tag: v2.6a2~16
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d48a2f77f01641ed806379358bd88eaf9e7644c8;p=python

Be sure to close the file.  2 places were deleting the file, so it was probably
fine, but the last change may be required for the test to pass on Windows.
Should we always close the mmap too?
---

diff --git a/Lib/test/test_mmap.py b/Lib/test/test_mmap.py
index 49ec78b842..6fecaf565b 100644
--- a/Lib/test/test_mmap.py
+++ b/Lib/test/test_mmap.py
@@ -161,6 +161,7 @@ class MmapTests(unittest.TestCase):
             pass
         else:
             self.fail("Able to resize readonly memory map")
+        f.close()
         del m, f
         self.assertEqual(open(TESTFN, "rb").read(), 'a'*mapsize,
                "Readonly memory map data file was modified")
@@ -217,6 +218,7 @@ class MmapTests(unittest.TestCase):
                "Copy-on-write test data file should not be modified.")
         # Ensuring copy-on-write maps cannot be resized
         self.assertRaises(TypeError, m.resize, 2*mapsize)
+        f.close()
         del m, f
 
         # Ensuring invalid access parameter raises exception
@@ -434,7 +436,7 @@ class MmapTests(unittest.TestCase):
         f = open(TESTFN, "rb")
         m = mmap.mmap(f.fileno(), mapsize, prot=mmap.PROT_READ)
         self.assertRaises(TypeError, m.write, "foo")
-
+        f.close()
 
     def test_error(self):
         self.assert_(issubclass(mmap.error, EnvironmentError))