From: Serhiy Storchaka <storchaka@gmail.com>
Date: Thu, 9 Feb 2017 18:02:37 +0000 (+0200)
Subject: Issue #29513: Fixed a reference leak in os.scandir() added in issue #29034.
X-Git-Tag: v3.6.1rc1~95
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d43ab05916639d478877d049f6dde4927f429190;p=python

Issue #29513: Fixed a reference leak in os.scandir() added in issue #29034.
---

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index dc3fb94c87..8f8ba255ec 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -11865,7 +11865,6 @@ ScandirIterator_finalize(ScandirIterator *iterator)
         }
     }
 
-    Py_CLEAR(iterator->path.object);
     path_cleanup(&iterator->path);
 
     /* Restore the saved exception. */
@@ -11969,12 +11968,6 @@ posix_scandir(PyObject *self, PyObject *args, PyObject *kwargs)
                                      path_converter, &iterator->path))
         goto error;
 
-    /* path_converter doesn't keep path.object around, so do it
-       manually for the lifetime of the iterator here (the refcount
-       is decremented in ScandirIterator_dealloc)
-    */
-    Py_XINCREF(iterator->path.object);
-
 #ifdef MS_WINDOWS
     iterator->first_time = 1;