From: Antony Dovgal Date: Thu, 5 Feb 2004 08:29:16 +0000 (+0000) Subject: fix bug #27149 X-Git-Tag: php-5.0.0b4RC1~116 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d3cd05c95ad3b39c174488f82aebb2f572f8b7b7;p=php fix bug #27149 (offset should start with 1) --- diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c index afe70092ef..2a66ad88c9 100644 --- a/ext/oci8/oci8.c +++ b/ext/oci8/oci8.c @@ -3841,11 +3841,11 @@ PHP_FUNCTION(oci_lob_save) if (offparam == -1) { offset = curloblen; - } else if (offparam >= curloblen) { + } else if ((ub4)offparam >= curloblen) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Offset is bigger than current LOB-Size - appending"); offset = curloblen; } else { - offset = offparam; + offset = (ub4)offparam; } } else if (zend_get_parameters_ex(1, &arg) == FAILURE) { WRONG_PARAM_COUNT; @@ -3859,6 +3859,10 @@ PHP_FUNCTION(oci_lob_save) RETURN_FALSE; } + if (offset <= 0) { + offset = 1; + } + CALL_OCI_RETURN(connection->error, OCILobWrite( connection->pServiceContext,