From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 16 Dec 2014 18:31:42 +0000 (-0500)
Subject: Fix file descriptor leak after failure of a \setshell command in pgbench.
X-Git-Tag: REL9_5_ALPHA1~1048
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d38e8d30cecea96a088330133e232c465a222d0a;p=postgresql

Fix file descriptor leak after failure of a \setshell command in pgbench.

If the called command fails to return data, runShellCommand forgot to
pclose() the pipe before returning.  This is fairly harmless in the current
code, because pgbench would then abandon further processing of that client
thread; so no more than nclients descriptors could be leaked this way.  But
it's not hard to imagine future improvements whereby that wouldn't be true.
In any case, it's sloppy coding, so patch all branches.  Found by Coverity.
---

diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
index 3453a1f7a6..397403f221 100644
--- a/contrib/pgbench/pgbench.c
+++ b/contrib/pgbench/pgbench.c
@@ -958,6 +958,7 @@ runShellCommand(CState *st, char *variable, char **argv, int argc)
 	{
 		if (!timer_exceeded)
 			fprintf(stderr, "%s: cannot read the result\n", argv[0]);
+		(void) pclose(fp);
 		return false;
 	}
 	if (pclose(fp) < 0)