From: Tomas Mraz <tmraz@fedoraproject.org>
Date: Wed, 28 Jan 2015 17:01:18 +0000 (+0100)
Subject: No need to call strcmp on already matched variables.
X-Git-Tag: cronie1.5.0~7
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d315d6e96af10d1ec15958671ea43606867e7b42;p=cronie

No need to call strcmp on already matched variables.
---

diff --git a/anacron/readtab.c b/anacron/readtab.c
index d01b4fa..4e04882 100644
--- a/anacron/readtab.c
+++ b/anacron/readtab.c
@@ -296,7 +296,7 @@ parse_tab_line(char *line)
             }
             Debug(("Jobs will start in the %02d:00-%02d:00 range.", range_start, range_stop));
         }
-        if (strncmp(env_var, "RANDOM_DELAY", 12) == 0) {
+        else if (strncmp(env_var, "RANDOM_DELAY", 12) == 0) {
             r = match_rx("^([[:digit:]]+)$", value, 0);
             if (r == -1) goto reg_err;
             if (r == 0) goto reg_invalid;
@@ -304,7 +304,7 @@ parse_tab_line(char *line)
             random_number = (int)unbiased_rand(atoi(value));
             Debug(("Randomized delay set: %d", random_number));
         }
-        if (strncmp(env_var, "PREFERRED_HOUR", 14) == 0) {
+        else if (strncmp(env_var, "PREFERRED_HOUR", 14) == 0) {
             r = match_rx("^([[:digit:]]+)$", value, 1, &pref_hour);
             if (r == -1) goto reg_err;