From: John McCall Date: Tue, 16 Apr 2013 22:32:04 +0000 (+0000) Subject: Don't put too much thought into whether or not to capture a X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d314abeffba04dffc101e4e71cc3a32ddeed4ae6;p=clang Don't put too much thought into whether or not to capture a type-dependent intermediate result in a postfix ++ pseudo- object operation. Test case by Tong Shen. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@179637 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Sema/SemaPseudoObject.cpp b/lib/Sema/SemaPseudoObject.cpp index 560efa5a4e..795cfbacfb 100644 --- a/lib/Sema/SemaPseudoObject.cpp +++ b/lib/Sema/SemaPseudoObject.cpp @@ -441,7 +441,8 @@ PseudoOpBuilder::buildIncDecOperation(Scope *Sc, SourceLocation opcLoc, QualType resultType = result.get()->getType(); // That's the postfix result. - if (UnaryOperator::isPostfix(opcode) && CanCaptureValueOfType(resultType)) { + if (UnaryOperator::isPostfix(opcode) && + (result.get()->isTypeDependent() || CanCaptureValueOfType(resultType))) { result = capture(result.take()); setResultToLastSemantic(); } diff --git a/test/SemaCXX/MicrosoftExtensions.cpp b/test/SemaCXX/MicrosoftExtensions.cpp index 07b93face9..ab3ff69f27 100644 --- a/test/SemaCXX/MicrosoftExtensions.cpp +++ b/test/SemaCXX/MicrosoftExtensions.cpp @@ -302,13 +302,14 @@ struct SP9 { T GetV() { return 0; } void SetV(T v) {} void f() { V = this->V; V < this->V; } - //void g() { V++; } - //void h() { V*=2; } + void g() { V++; } + void h() { V*=2; } }; struct SP10 { SP10(int v) {} bool operator<(const SP10& v) { return true; } SP10 operator*(int v) { return *this; } + SP10 operator+(int v) { return *this; } SP10& operator=(const SP10& v) { return *this; } }; void TestSP9() { @@ -329,6 +330,6 @@ void TestSP9() { SP9 c3; c3.f(); // Overloaded binary op operand - //c3.g(); // Overloaded incdec op operand - //c3.h(); // Overloaded unary op operand + c3.g(); // Overloaded incdec op operand + c3.h(); // Overloaded unary op operand }