From: Felipe Pena <felipe@php.net>
Date: Mon, 3 Nov 2008 20:45:43 +0000 (+0000)
Subject: - Fixed endless loop in PDOStatement::debugDumpParams()
X-Git-Tag: BEFORE_HEAD_NS_CHANGE~102
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d2edc09737a41ec0fc8b569ec7b349f8102c1830;p=php

- Fixed endless loop in PDOStatement::debugDumpParams()
  patch by: Jonah H. Harris <jonah.harris at gmail dot com>
---

diff --git a/ext/pdo/pdo_stmt.c b/ext/pdo/pdo_stmt.c
index 3f95552f4f..bfdd026cda 100755
--- a/ext/pdo/pdo_stmt.c
+++ b/ext/pdo/pdo_stmt.c
@@ -2211,6 +2211,7 @@ static PHP_METHOD(PDOStatement, debugDumpParams)
 				param->is_param,
 				param->param_type);
 			
+			zend_hash_move_forward_ex(stmt->bound_params, &pos);
 		}
 	}
 
diff --git a/ext/pdo_sqlite/tests/debugdumpparams_001.phpt b/ext/pdo_sqlite/tests/debugdumpparams_001.phpt
new file mode 100644
index 0000000000..d85784a4f1
--- /dev/null
+++ b/ext/pdo_sqlite/tests/debugdumpparams_001.phpt
@@ -0,0 +1,31 @@
+--TEST--
+Testing PDOStatement::debugDumpParams() with bound params
+--SKIPIF--
+<?php
+if (!extension_loaded('pdo_sqlite')) print 'skip not loaded';
+?>
+--FILE--
+<?php
+
+$db = new pdo('sqlite:memory');
+
+$x= $db->prepare('select :a, :b');
+$x->bindValue(':a', 1, PDO::PARAM_INT);
+$x->bindValue(':b', 'foo');
+var_dump($x->debugDumpParams());
+
+?>
+--EXPECT--
+SQL: [13] select :a, :b
+Params:  2
+Key: Position #0:
+paramno=-1
+name=[2] :a
+is_param=1
+param_type=1
+Key: Position #0:
+paramno=-1
+name=[2] :b
+is_param=1
+param_type=2
+NULL