From: Fiona Glaser <fiona@x264.com>
Date: Wed, 4 Nov 2009 07:15:35 +0000 (-0800)
Subject: Fix extremely rare infinite loop in 2-pass VBV
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d2e7a5a6bf716b2cc1ad32bb842d28935060ccc3;p=libx264

Fix extremely rare infinite loop in 2-pass VBV
Implicit conversion from double->float lost enough precision to cause the loop termination condition to never trigger.
Bug report by Tal Aloni.
---

diff --git a/encoder/ratecontrol.c b/encoder/ratecontrol.c
index 06911421..49e88f70 100644
--- a/encoder/ratecontrol.c
+++ b/encoder/ratecontrol.c
@@ -37,13 +37,13 @@ typedef struct
 {
     int pict_type;
     int kept_as_ref;
-    float qscale;
+    double qscale;
     int mv_bits;
     int tex_bits;
     int misc_bits;
     uint64_t expected_bits; /*total expected bits up to the current frame (current one excluded)*/
     double expected_vbv;
-    float new_qscale;
+    double new_qscale;
     int new_qp;
     int i_count;
     int p_count;