From: David Soria Parra <dsp@php.net>
Date: Wed, 25 Nov 2009 23:38:34 +0000 (+0000)
Subject: Also allow base 62 for gmp_init as requested in (#50283)
X-Git-Tag: php-5.4.0alpha1~191^2~2339
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d25630ee14faf4e4f818ef60a9b67abee27d6bf9;p=php

Also allow base 62 for gmp_init as requested in (#50283)
---

diff --git a/ext/gmp/gmp.c b/ext/gmp/gmp.c
index c9da712fd8..6383be5a06 100644
--- a/ext/gmp/gmp.c
+++ b/ext/gmp/gmp.c
@@ -754,7 +754,7 @@ ZEND_FUNCTION(gmp_init)
 		return;
 	}
 
-	if (base && (base < 2 || base > 36)) {
+	if (base && (base < 2 || base > 62)) {
 		php_error_docref(NULL TSRMLS_CC, E_WARNING, "Bad base for conversion: %ld (should be between 2 and 36)", base);
 		RETURN_FALSE;
 	}
diff --git a/ext/gmp/tests/bug50283.phpt b/ext/gmp/tests/bug50283.phpt
index d2c3165fa7..e8132a78f3 100644
--- a/ext/gmp/tests/bug50283.phpt
+++ b/ext/gmp/tests/bug50283.phpt
@@ -12,7 +12,8 @@ printf("Decimal: %s, 1-based: %s\n", gmp_strval($a), gmp_strval($a,1));
 printf("Decimal: %s, -37-based: %s\n", gmp_strval($a), gmp_strval($a,-37));
 printf("Decimal: %s, 37-based: %s\n", gmp_strval($a), gmp_strval($a,37));
 printf("Decimal: %s, 62-based: %s\n", gmp_strval($a), gmp_strval($a,62));
-printf("Decimal: %s, 63-based: %s\n", gmp_strval($a), gmp_strval($a,63));
+printf("Decimal: %s, 63-based: %s\n\n", gmp_strval($a), gmp_strval($a,63));
+printf("Base 32 and 62-based: %s\n", gmp_strval(gmp_init("gh82179fbf5", 32), 62));
 ?>
 --EXPECTF--
 Decimal: 71915494046709, -36-based: PHPISCOOL
@@ -31,3 +32,5 @@ Decimal: 71915494046709, 62-based: KQ6yq741
 
 Warning: gmp_strval(): Bad base for conversion: 63 in %s on line 10
 Decimal: 71915494046709, 63-based: 
+
+Base 32 and 62-based: 1NHkAcdIiD