From: Jack Jansen <jack.jansen@cwi.nl>
Date: Thu, 24 Jul 2003 22:25:03 +0000 (+0000)
Subject: Don't export the SPB type as "SPB", because it shadows the method SPB,
X-Git-Tag: v2.3c2~3
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d1f46c8970b782875f168f3401232d82e485cf43;p=python

Don't export the SPB type as "SPB", because it shadows the method SPB,
which is really important. This is a stopgap measure, as only the generated
C code is adapted. Fixes #776533.
---

diff --git a/Mac/Modules/snd/_Sndmodule.c b/Mac/Modules/snd/_Sndmodule.c
index c27fab626d..0075c986be 100644
--- a/Mac/Modules/snd/_Sndmodule.c
+++ b/Mac/Modules/snd/_Sndmodule.c
@@ -1150,8 +1150,11 @@ void init_Snd(void)
 	PyModule_AddObject(m, "SndChannelType", (PyObject *)&SndChannel_Type);
 	SPB_Type.ob_type = &PyType_Type;
 	if (PyType_Ready(&SPB_Type) < 0) return;
+#if 0
+	/* This would shadow the SPB routine, which is bad news (it is important) */
 	Py_INCREF(&SPB_Type);
 	PyModule_AddObject(m, "SPB", (PyObject *)&SPB_Type);
+#endif
 	/* Backward-compatible name */
 	Py_INCREF(&SPB_Type);
 	PyModule_AddObject(m, "SPBType", (PyObject *)&SPB_Type);