From: Barry Warsaw Date: Thu, 4 Oct 2001 18:18:37 +0000 (+0000) Subject: TestIterators: Tim Peters suggests a more succinct spelling of X-Git-Tag: v2.2.1c1~1458 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d1de6eacf22caf95aba6d76058267c8f5b6543b8;p=python TestIterators: Tim Peters suggests a more succinct spelling of "listify an iterator". --- diff --git a/Lib/test/test_email.py b/Lib/test/test_email.py index c349974325..0a6b8083a8 100644 --- a/Lib/test/test_email.py +++ b/Lib/test/test_email.py @@ -793,17 +793,13 @@ class TestIterators(TestEmailBase): # First a simple non-multipart message msg = self._msgobj('msg_01.txt') it = Iterators.body_line_iterator(msg) - lines = [] - for line in it: - lines.append(line) + lines = list(it) eq(len(lines), 6) eq(EMPTYSTRING.join(lines), msg.get_payload()) # Now a more complicated multipart msg = self._msgobj('msg_02.txt') it = Iterators.body_line_iterator(msg) - lines = [] - for line in it: - lines.append(line) + lines = list(it) eq(len(lines), 43) eq(EMPTYSTRING.join(lines), openfile('msg_19.txt').read()) @@ -811,12 +807,8 @@ class TestIterators(TestEmailBase): eq = self.assertEqual msg = self._msgobj('msg_04.txt') it = Iterators.typed_subpart_iterator(msg, 'text') - lines = [] - subparts = 0 - for subpart in it: - subparts += 1 - lines.append(subpart.get_payload()) - eq(subparts, 2) + lines = [subpart.get_payload() for subpart in it] + eq(len(lines), 2) eq(EMPTYSTRING.join(lines), """\ a simple kind of mirror to reflect upon our own