From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 25 Mar 2010 15:50:22 +0000 (+0000)
Subject: Fix ginint4_queryextract() to actually do what it was intended to do for an
X-Git-Tag: REL8_3_11~30
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d1bc3525c072a4c6bbc7bbba5da68cd30adfd1a6;p=postgresql

Fix ginint4_queryextract() to actually do what it was intended to do for an
unsatisfiable query, such as indexcol && empty_array.  It should return -1
to tell GIN no scan is required; but silly typo disabled the logic for that,
resulting in unnecessary "GIN indexes do not support whole-index scans" error.
Per bug report from Jeff Trout.

Back-patch to 8.3 where the logic was introduced.
---

diff --git a/contrib/intarray/_int_gin.c b/contrib/intarray/_int_gin.c
index 6856a68e03..37ea55b8d1 100644
--- a/contrib/intarray/_int_gin.c
+++ b/contrib/intarray/_int_gin.c
@@ -57,7 +57,7 @@ ginint4_queryextract(PG_FUNCTION_ARGS)
 		}
 	}
 
-	if (nentries == 0)
+	if (*nentries == 0)
 	{
 		switch (strategy)
 		{