From: PatR <rankin@nethack.org>
Date: Wed, 4 May 2022 21:19:16 +0000 (-0700)
Subject: skipinvert handling in tty menus
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d1b14e08c4d1a7bda95473db7ac9f67749e6144f;p=nethack

skipinvert handling in tty menus

Select all and unselect all were passing the wrong third argument to
menuitem_invert_test().  Select page and unselect page had it right.
---

diff --git a/win/tty/wintty.c b/win/tty/wintty.c
index 113cf883f..5ddfabdd4 100644
--- a/win/tty/wintty.c
+++ b/win/tty/wintty.c
@@ -2199,7 +2199,8 @@ process_menu_window(winid window, struct WinDesc *cw)
                 for (curr = cw->mlist; curr; curr = curr->next) {
                     if (!curr->identifier.a_void /* not selectable */
                         || curr->selected /* already selected */
-                        || !menuitem_invert_test(1, curr->itemflags, TRUE))
+                        /* FALSE: not currently selected */
+                        || !menuitem_invert_test(1, curr->itemflags, FALSE))
                         continue;
                     curr->selected = TRUE;
                 }
@@ -2215,7 +2216,8 @@ process_menu_window(winid window, struct WinDesc *cw)
             for (curr = cw->mlist; curr; curr = curr->next) {
                 if (!curr->identifier.a_void /* not selectable */
                     || !curr->selected /* already de-selected */
-                    || !menuitem_invert_test(2, curr->itemflags, FALSE))
+                    /* TRUE: currently selected */
+                    || !menuitem_invert_test(2, curr->itemflags, TRUE))
                     continue;
                 curr->selected = FALSE;
                 curr->count = -1;