From: Guido van Rossum <guido@python.org>
Date: Fri, 18 Jan 2008 20:53:37 +0000 (+0000)
Subject: Fix an edge case whereby the __del__() method of a classic class could
X-Git-Tag: v2.5.2c1~73
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d187381b812e2ee7f7a65e3b9ff643e6e6429c34;p=python

Fix an edge case whereby the __del__() method of a classic class could
create a new weakref to the object.
---

diff --git a/Objects/classobject.c b/Objects/classobject.c
index 89cca5969d..b4b17f9077 100644
--- a/Objects/classobject.c
+++ b/Objects/classobject.c
@@ -646,6 +646,16 @@ instance_dealloc(register PyInstanceObject *inst)
 	 */
 	assert(inst->ob_refcnt > 0);
 	if (--inst->ob_refcnt == 0) {
+
+		/* New weakrefs could be created during the finalizer call.
+		    If this occurs, clear them out without calling their
+		    finalizers since they might rely on part of the object
+		    being finalized that has already been destroyed. */
+		while (inst->in_weakreflist != NULL) {
+			_PyWeakref_ClearRef((PyWeakReference *)
+                                            (inst->in_weakreflist));
+		}
+
 		Py_DECREF(inst->in_class);
 		Py_XDECREF(inst->in_dict);
 		PyObject_GC_Del(inst);