From: Douglas Gregor <dgregor@apple.com>
Date: Fri, 27 Mar 2009 05:10:56 +0000 (+0000)
Subject: Remove the code insertion hint for implicit int. Too often, we're wrong about this... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d17a9e5a29ef076e31d012d7254b526769c386f6;p=clang

Remove the code insertion hint for implicit int. Too often, we're wrong about this hint, so it loses its usefulness. Maybe some day we can make the hint smart enough to be useful.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@67823 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaType.cpp b/lib/Sema/SemaType.cpp
index dbe19e3434..21254ea054 100644
--- a/lib/Sema/SemaType.cpp
+++ b/lib/Sema/SemaType.cpp
@@ -114,9 +114,12 @@ QualType Sema::ConvertDeclSpecToType(const DeclSpec &DS) {
       unsigned DK = getLangOptions().CPlusPlus && !getLangOptions().Microsoft?
           diag::err_missing_type_specifier
         : diag::warn_missing_type_specifier;
-      Diag(DS.getSourceRange().getBegin(), DK)
-        << CodeModificationHint::CreateInsertion(DS.getSourceRange().getBegin(),
-                                                 "int");
+      Diag(DS.getSourceRange().getBegin(), DK);
+
+      // FIXME: If we could guarantee that the result would be
+      // well-formed, it would be useful to have a code insertion hint
+      // here. However, after emitting this warning/error, we often
+      // emit other errors.
     }
       
     // FALL THROUGH.